Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHM tweaks #15274

Merged
merged 4 commits into from
Dec 1, 2024
Merged

SHM tweaks #15274

merged 4 commits into from
Dec 1, 2024

Conversation

NickM-27
Copy link
Collaborator

@NickM-27 NickM-27 commented Nov 30, 2024 •
edited
Loading

Proposed change

  • Resets the max number of SHM frames to 50 and adds an environment variable so users can override the default behavior
  • Fix review maintainer when recordings are disabled

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code
  • Documentation Update

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format frigate)

@netlify Netlify
Copy link

netlify bot commented Nov 30, 2024 •
edited
Loading

✅ Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit d322989
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/674c75a954264f00092efbdf

@hawkeye217
Copy link
Collaborator

Looks like mypy failed on this one

@hawkeye217
Copy link
Collaborator

Also I think the ruff changes on your other one would be reverted by this one.

@NickM-27 NickM-27 changed the title Use env var to control max number of frames SHM tweaks Dec 1, 2024
@hawkeye217 hawkeye217 merged commit 002fdea into dev Dec 1, 2024
13 checks passed
@hawkeye217 hawkeye217 deleted the set-shm-limit branch December 1, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkeye217 hawkeye217 hawkeye217 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NickM-27 @hawkeye217