Fix webUI success / error messages (#7820)

* Fix export error handling * Ensure that config editor success / error is updated each time * Set response * Formatting
blakeblackshear · Sep 16, 2023 · b9e6afa · b9e6afa
1 parent 9185753
commit b9e6afa
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/frigate/http.py b/frigate/http.py
@@ -1646,7 +1646,12 @@ def export_recording(camera_name: str, start_time, end_time):
     )
 
     if recordings_count <= 0:
-        return "No recordings found for time range", 400
+        return make_response(
+            jsonify(
+                {"success": False, "message": "No recordings found for time range"}
+            ),
+            400,
+        )
 
     exporter = RecordingExporter(
         current_app.frigate_config,

diff --git a/web/src/routes/Config.jsx b/web/src/routes/Config.jsx
@@ -28,10 +28,13 @@ export default function Config() {
       })
       .then((response) => {
         if (response.status === 200) {
+          setError('');
           setSuccess(response.data);
         }
       })
       .catch((error) => {
+        setSuccess('');
+
         if (error.response) {
           setError(error.response.data.message);
         } else {

diff --git a/web/src/routes/Export.jsx b/web/src/routes/Export.jsx
@@ -58,7 +58,7 @@ export default function Export() {
         }
       })
       .catch((error) => {
-        if (error.response) {
+        if (error.response?.data?.message) {
           setMessage({ text: `Failed to start export: ${error.response.data.message}`, error: true });
         } else {
           setMessage({ text: `Failed to start export: ${error.message}`, error: true });