-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade protobuf v4.27.2 #28
base: main
Are you sure you want to change the base?
Upgrade protobuf v4.27.2 #28
Conversation
@spensonshih @tdieff Is there any tip about how to fix the unit tests by running Single test
|
@ee08b397 , looks like you found an issue with the build. I think the issue is because in the protoc-jar module, the binaries under the bin/**/*.exe are only included in the jar using the maven-assembly-plugin on the package phase. So if you run the test phase only, then the unit tests for the plugin cannot find the binaries. For now, you can run |
Thanks @spensonshih. The issue is raised in #29. |
Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], or [CONTRIB]. If a new feature introduces breaking changes for the or configuration files, please also add [BREAKING].
Description
[Describe the issue or feature that this pull request is addressing. Provide context and any relevant links to issues or documentation.]
Changes Made
[Describe the changes made in this pull request, including any new code or dependencies added, removed, or updated.]
Definition of Done
Before submitting this pull request, please ensure that the following criteria have been met:
Additional Notes
[Add any additional notes or context for the reviewer or future maintainers of this code.]
Thank you for submitting!