Layout adjustments and responsive design #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That looks like a lot of changes. Is the main issue you're addressing that you were getting security errors when copying to clipboard? Also, could you please restore the indentation of the <head> element? It would make the diff more readable. |
Cyklon3000
commented
Mar 3, 2023
| }; | ||
|
|
||
| // Requires save connection (HTTPS) | ||
| function copyClipboardCanvas() |
There was a problem hiding this comment.
Potential implementation of copying to clipboard implemented, but in order for browsers to actually copy those files into the clipboard they require a HTTPS connection, there for a implementation that doesn't work at the moment, because the website is missing a security certificate. (disabled by setting the buttons style to "display:none;" in line 196)
Cyklon3000
commented
Mar 3, 2023
| <script nomodule src="https://unpkg.com/[email protected]/dist/ionicons/ionicons.js"></script> | ||
| </body> | ||
|
|
||
| </html> |
There was a problem hiding this comment.
reimplemented indentation for and
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redesign of website (kept vanilla look), responsivity using grid layout,
random seed on load,
adjusted basis for clipboard copying (not available because of unsuficcient security),
Links to generator in 'How it works',
Patreon support link added (ionic icons are free to use, without attributution)