Skip to content

Commit

Permalink
Fix: Icons - Replace edit as acorn design system #935
Browse files Browse the repository at this point in the history
  • Loading branch information
black7375 committed Jul 6, 2024
1 parent 362f34b commit a1f1ff5
Show file tree
Hide file tree
Showing 11 changed files with 30 additions and 27 deletions.
20 changes: 10 additions & 10 deletions css/leptonChrome.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions css/leptonChromeESR.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions css/leptonContent.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions css/leptonContentESR.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions icons/edit-active.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion src/icons/_activity_stream.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
--menuitem-image: url("../icons/unpin-tab.svg");
}
.context-menu-item span[data-l10n-id="newtab-menu-edit-topsites"] {
--menuitem-image: url("chrome://global/skin/icons/edit.svg");
--menuitem-image: url("../icons/edit-active.svg");
}
.context-menu-item span[data-l10n-id="newtab-menu-bookmark"] {
--menuitem-image: url("chrome://browser/skin/bookmark.svg");
Expand Down
2 changes: 1 addition & 1 deletion src/icons/_global_menubar.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
--menuitem-image: url("../icons/mail-inbox-all.svg");
}
#edit-menu {
--menuitem-image: url("chrome://global/skin/icons/edit.svg");
--menuitem-image: url("../icons/edit-active.svg");
}
#view-menu {
--menuitem-image: url("../icons/content-view.svg");
Expand Down
2 changes: 1 addition & 1 deletion src/icons/context_menu/_others.scss
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
--menuitem-image: url("chrome://global/skin/icons/check.svg");
}
#blockedPopupOptions > menuitem[oncommand="gPopupBlockerObserver.editPopupSettings();"] {
--menuitem-image: url("chrome://global/skin/icons/edit.svg");
--menuitem-image: url("../icons/edit-active.svg");
}
#blockedPopupDontShowMessage {
/* checkbox */
Expand Down
2 changes: 1 addition & 1 deletion src/icons/context_menu/_place.scss
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
#placesContext_show_bookmark\:info,
#placesContext_show\:info,
#placesContext_show_folder\:info {
--menuitem-image: url("chrome://global/skin/icons/edit.svg");
--menuitem-image: url("../icons/edit-active.svg");
}
#placesContext_deleteBookmark,
#placesContext_deleteFolder,
Expand Down
2 changes: 1 addition & 1 deletion src/icons/context_menu/_tab_toolbar.scss
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ menuitem.viewCustomizeToolbar {
}
}
#tm-renameTab {
--menuitem-image: url("chrome://global/skin/icons/edit.svg");
--menuitem-image: url("../icons/edit-active.svg");
}
#tm-copyTabUrl {
--menuitem-image: url("../icons/link.svg");
Expand Down
2 changes: 1 addition & 1 deletion src/icons/fork_browsers/_floorp.scss
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
}

&[data-l10n-id="make-browsercss-file"] {
--menuitem-image: url("chrome://global/skin/icons/edit.svg");
--menuitem-image: url("../icons/edit-active.svg");
}
&[data-l10n-id="open-css-folder"] {
--menuitem-image: var(--uc-folder-icon);
Expand Down

2 comments on commit a1f1ff5

@thunderstone135
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that the File, Edit, and View icons are 1px bigger than the other icons 👇
Imgur

Open the image in a new tab and zoom it beyond 100%.
Notice that the other icons beside File, Edit, and View, are not hitting the red line.

With that said, I can't seem to reduce their size in userChrome.css.

@black7375
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thunderstone135 I got it.
Thanks to feedback.

I'm not a designer, so this is a bit tricky.

Please sign in to comment.