Refactor bet_size.rs for issue 16 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkushigian
force-pushed
the
issue16-refactor-bet_size.rs
branch
from
e50a976 to
f1142c8
Compare
bkushigian
changed the base branch from
main
to
bkushigian/issue14-serde-tree-config
bkushigian
merged commit 4ee82b8
into
bkushigian/issue14-serde-tree-config
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to address #16
This PR addresses points in issue #16:
Additionally, this PR implements some serialization/deserialization (which probably belongs in parent PR but I'm lazy), and implements
try_from_sizesandas_valid_betsthat moves logic about valid bet sizes (versus raise sizes) out ofBetSize