Issue2: reload and resolve #11

bkushigian · 2024-10-07T00:14:27Z

This PR addresses issue #2

Reload And Resolve Workaround

bkushigian

Some stuff for both @JacobVanGeffen and @bkushigian to address

examples/file_io.rs

src/file.rs

src/game/base.rs

src/game/interpreter.rs

src/game/node.rs

src/game/serialization.rs

src/game/interpreter.rs

…o_big.rs

bkushigian

Addressed a bunch of review comments

src/file.rs

JacobVanGeffen

I think this is looking nice!

bkushigian and others added 30 commits August 18, 2024 17:33

beginning branch refactor

c74cad1

Branch Refactor: added file_io_debug.rs

81764c7

Branch refactor

8824791

Strategies by private hand, plus transpose in sliceops

9821469

Tmp commit

e0b0db7

tmp commit

c2459fa

Refactor: moved test into branch

4159f13

Refactor continue

1e0067b

Documenting solve_recursive

f6b0861

Added documentation, renamed variables for clarity

aa10c4c

Fixed merge conflict

18f6d60

Fixed thing that was missed in previous merge

a5dc463

Tmp commit

9c4a310

Removed warnings from example

f30f70a

tmp commit from pair programming to fix flop and turn save-and-resolve

b5c3807

tmp commit for debugging

963ed40

Cherry pick updated State, fixed some breakages

59cf5f2

Tidied imports

818f556

tmp commit

70bde78

tmp commit; resolve uses normalized strategy for locking

9cd7ed5

Fixed warnings

01c5adb

Only lock flop and turn nodes

47600b9

hacky_reload_and_resolve working

3fbfa82

Updated file_io example

fdda64c

Updated file_io

ab8a785

renamed hacky_reload_and_resolve, implemented reload_and_resolve

58365a9

Removed temporary node locks used for resolve, added docs, tests

22e9395

Merge branch 'main' into bkushigian/issue2_workaround

e33912c

Merge branch 'docs' into bkushigian/issue2_workaround

d9dc996

Removed unnecessary borrow

af91af2

bkushigian added 6 commits October 7, 2024 10:39

Merge and fixed several bugs, failing tests

f2668fb

Fix bug in conditional compilation rename

29e67ea

Fixed some example comments and names

0d9f5a7

Removed print debug statements

68083a8

Updated examples/file_io.rs for clarity

f61782d

Merge pull request #5 from bkushigian/bkushigian/issue2_workaround

924e3a4

Reload And Resolve Workaround

bkushigian changed the base branch from main to v0.1.1 October 7, 2024 19:33

bkushigian commented Oct 7, 2024

View reviewed changes

JacobVanGeffen reviewed Oct 7, 2024

View reviewed changes

src/game/interpreter.rs Outdated Show resolved Hide resolved

bkushigian added 3 commits October 7, 2024 13:34

Checked out file_io.rs from main, and moved updated version to file_i…

1038f63

…o_big.rs

Small refactor, comment for clarity

d84bb46

Resolved comments in review

a3b84e4

bkushigian commented Oct 7, 2024

View reviewed changes

src/file.rs Outdated Show resolved Hide resolved

bkushigian and others added 6 commits October 7, 2024 16:58

Updated example to handle Result

7c78c1e

Handle more uses of node_lock (added Result)

e56352f

CHANGES.md

07b1d85

CHANGES.md

2dc57a7

Changed CHANGES.md heaer

e974001

Do/remove done TODOs

62a0eee

JacobVanGeffen approved these changes Nov 24, 2024

View reviewed changes

bkushigian merged commit ca00f7c into v0.1.1 Nov 26, 2024
2 checks passed

bkushigian deleted the bkushigian/issue2 branch November 26, 2024 05:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue2: reload and resolve #11

Issue2: reload and resolve #11

bkushigian commented Oct 7, 2024

bkushigian left a comment

bkushigian left a comment

JacobVanGeffen left a comment

Issue2: reload and resolve #11

Issue2: reload and resolve #11

Conversation

bkushigian commented Oct 7, 2024

bkushigian left a comment

Choose a reason for hiding this comment

bkushigian left a comment

Choose a reason for hiding this comment

JacobVanGeffen left a comment

Choose a reason for hiding this comment