Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use maven-publish to support React Native 0.67.1 #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

geraintwhite
Copy link

@geraintwhite geraintwhite commented Jun 1, 2022

@fukemy
Copy link

fukemy commented Oct 25, 2022

hi, how can i get this patch using npm? Thanks so much

@HalilFocic
Copy link

@grit96 Could you please provide either patch with npm or short summary of how to fix this bug?

@geraintwhite
Copy link
Author

Hi, I'm not the maintainer of this repo. You can manually make the changes and use patch-package to preserve them.

@geraintwhite
Copy link
Author

I would be willing to take over maintainership if @bkdev98 will allow it.

@fukemy
Copy link

fukemy commented Nov 4, 2022

@grit96 Could you please provide either patch with npm or short summary of how to fix this bug?

U can use https://github.com/linhvovan29546/react-native-full-screen-notification-incoming-call instead

@rohinipf
Copy link

rohinipf commented Mar 14, 2024

Did anyone figure out how to make this package work with newer react-native versions like 0.73.5 ?

Even after applying the patch provided by @geraintwhite, I get the following error:

A problem occurred configuring project ':react-native-incoming-call'.
> Could not resolve all files for configuration ':react-native-incoming-call:implementation'.
   > Could not resolve com.facebook.react:react-native:+.
     Required by:
         project :react-native-incoming-call
      > Cannot choose between the following variants of com.facebook.react:react-android:0.73.5:
          - debugVariantDefaultRuntimePublication
          - releaseVariantDefaultRuntimePublication
        All of them match the consumer attributes:
          - Variant 'debugVariantDefaultRuntimePublication' capability com.facebook.react:react-android:0.73.5:
              - Unmatched attributes:
                  - Provides com.android.build.api.attributes.BuildTypeAttr 'debug' but the consumer didn't ask for it
                  - Provides org.gradle.category 'library' but the consumer didn't ask for it
                  - Provides org.gradle.dependency.bundling 'external' but the consumer didn't ask for it
                  - Provides org.gradle.libraryelements 'aar' but the consumer didn't ask for it
                  - Provides org.gradle.status 'release' but the consumer didn't ask for it
                  - Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it
          - Variant 'releaseVariantDefaultRuntimePublication' capability com.facebook.react:react-android:0.73.5:
              - Unmatched attributes:
                  - Provides com.android.build.api.attributes.BuildTypeAttr 'release' but the consumer didn't ask for it
                  - Provides org.gradle.category 'library' but the consumer didn't ask for it
                  - Provides org.gradle.dependency.bundling 'external' but the consumer didn't ask for it
                  - Provides org.gradle.libraryelements 'aar' but the consumer didn't ask for it
                  - Provides org.gradle.status 'release' but the consumer didn't ask for it
                  - Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it

@fukemy
Copy link

fukemy commented Mar 15, 2024

Did anyone figure out how to make this package work with newer react-native versions like 0.73.5 ?

Even after applying the patch provided by @geraintwhite, I get the following error:

A problem occurred configuring project ':react-native-incoming-call'.
> Could not resolve all files for configuration ':react-native-incoming-call:implementation'.
   > Could not resolve com.facebook.react:react-native:+.
     Required by:
         project :react-native-incoming-call
      > Cannot choose between the following variants of com.facebook.react:react-android:0.73.5:
          - debugVariantDefaultRuntimePublication
          - releaseVariantDefaultRuntimePublication
        All of them match the consumer attributes:
          - Variant 'debugVariantDefaultRuntimePublication' capability com.facebook.react:react-android:0.73.5:
              - Unmatched attributes:
                  - Provides com.android.build.api.attributes.BuildTypeAttr 'debug' but the consumer didn't ask for it
                  - Provides org.gradle.category 'library' but the consumer didn't ask for it
                  - Provides org.gradle.dependency.bundling 'external' but the consumer didn't ask for it
                  - Provides org.gradle.libraryelements 'aar' but the consumer didn't ask for it
                  - Provides org.gradle.status 'release' but the consumer didn't ask for it
                  - Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it
          - Variant 'releaseVariantDefaultRuntimePublication' capability com.facebook.react:react-android:0.73.5:
              - Unmatched attributes:
                  - Provides com.android.build.api.attributes.BuildTypeAttr 'release' but the consumer didn't ask for it
                  - Provides org.gradle.category 'library' but the consumer didn't ask for it
                  - Provides org.gradle.dependency.bundling 'external' but the consumer didn't ask for it
                  - Provides org.gradle.libraryelements 'aar' but the consumer didn't ask for it
                  - Provides org.gradle.status 'release' but the consumer didn't ask for it
                  - Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it
exclusiveContent {
            // We get React Native's Android binaries exclusively through npm,
            // from a local Maven repo inside node_modules/react-native/.
            // (The use of exclusiveContent prevents looking elsewhere like Maven Central
            // and potentially getting a wrong version.)
            filter {
                includeGroup "com.facebook.react"
            }
            forRepository {
                maven {
                    url "$rootDir/../node_modules/react-native/android"
                }
            }
        }

@rohinipf
Copy link

exclusiveContent {
            // We get React Native's Android binaries exclusively through npm,
            // from a local Maven repo inside node_modules/react-native/.
            // (The use of exclusiveContent prevents looking elsewhere like Maven Central
            // and potentially getting a wrong version.)
            filter {
                includeGroup "com.facebook.react"
            }
            forRepository {
                maven {
                    url "$rootDir/../node_modules/react-native/android"
                }
            }
        }

@fukemy I dumped this under repositories like below but I still receive the same error. Was I supposed to place it somewhere else? Maybe under the buildscript ?

repositories {
    // ref: https://www.baeldung.com/maven-local-repository
    mavenLocal()
    maven {
        // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
        url "$rootDir/../node_modules/react-native/android"
    }
    maven {
        // Android JSC is installed from npm
        url "$rootDir/../node_modules/jsc-android/dist"
    }
    google()
    jcenter()

    exclusiveContent {
        // We get React Native's Android binaries exclusively through npm,
        // from a local Maven repo inside node_modules/react-native/.
        // (The use of exclusiveContent prevents looking elsewhere like Maven Central
        // and potentially getting a wrong version.)
        filter {
            includeGroup "com.facebook.react"
        }
        forRepository {
            maven {
                url "$rootDir/../node_modules/react-native/android"
            }
        }
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible version
4 participants