-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add spanish translation, Literate.jl backend #30
base: master
Are you sure you want to change the base?
Conversation
This is very nice. I understand that this is still WIP (but having checked this it could just be merged - right?, as in the PR you just provide the .jl files that would reproduce what we have now - right?) |
I will fork |
PHEW! All done! I will ping some spanish speaking friends to look over it. |
|
||
DataFrame([rand(3) for i in 1:3]) | ||
|
||
# Por ahora podemos construir un `DataFrame` de un `Vector` de átomos, creando un `DataFrame` con una sola hilera. En versiones futuras de DataFrames.jl, esto arrojará un error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we delete this? Since it will be a 1.0 compatible anyway so there's no need to talk about deprecations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah there's a couple of pre DataFrames 1.0 kinks that can be cleaned up. I'm waiting to run the notebooks and test that everything works to filter many of these out. I still don't know much about DataFrames so I don't know what is/isn't design yet.
Co-authored-by: pdeffebach <[email protected]>
Co-authored-by: pdeffebach <[email protected]>
Co-authored-by: pdeffebach <[email protected]>
Co-authored-by: pdeffebach <[email protected]>
@miguelraz: please let me know when this is good to merge |
I have to fix some errors on the main source files: |
OK. Thank you! |
Also there is some funky stuff with |
Where is |
|
||
# Podemos reorganizar el vector `names(x)` como sea necesario, creando un nuevo DataFrame en el proceso. | ||
|
||
srand(1234) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is one example @bkamins, but they are everywhere...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be Random.seed!(1234)
. Where did you get srand
from? Here is the source (from my notebooks on master
):
using Random
Random.seed!(1234)
x[:, shuffle(names(x))]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can easily replace with a regex in both portuguese and spanish. I just followed the .jl
converted by @miguelraz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As commented on Slack it seems that @miguelraz did not use master
for doing the conversion. The fix should be easy hopefully.
# (Traducción por Miguel Raz, Abril 18, 2021) | ||
|
||
using DataFrames # cargar paquete | ||
srand(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another one @bkamins (it shows 16 times in the files)
Yup, it's my bad @storopoli - I forked the master on github but had a stale repo locally which I made the notebooks from. I'm changing the |
@miguelraz - I am back to this PR. Is it ready to merge or there are still some issues to resolve. |
Still issues. I'll get to it today and ping you. |
Sure - no rush. I am porting other tutorials to DataFrames.jl 1.1, so I have my pipeline filled with work :). |
To avoid blocking users I have updated the Jupyter Notebooks to 1.1.1 release of DataFrames.jl. Fortunately the changes are minor:
|
This PR is a WIP with at least 2 goals:
Rationale:
ipynyb
->.jl
Literate.jl converter, I already have the files that Literate.jl would use to produce the current.ipynb
notebooks. It seems silly to use them for Spanish and not make them available to the rest of the tutorials (as a Portuguese translation was also suggested, this will reduce shared work.)