Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: resolve unnecessary linkcheck redirects #1226

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Conversation

bjlittle
Copy link
Owner

@bjlittle bjlittle commented Nov 25, 2024

🚀 Pull Request

Description

This pull-request addresses the fixable documentation linkcheck redirects to their permanent URLs.

Note that, after performing a make linkcheck simply check the sphinx auto-generated _build/linkcheck/output.txt.

The remaining redirects are attributed to the URLs generated by sphinx when creating references into the pyvista API.


@github-actions github-actions bot added type: documentation Auto-labelled for doc/* and docs/* branches type: examples Auto-labelled for ex/*, example/* and examples/* branches type: bug Auto-labelled for bug/*, fix/* and patch/* branches labels Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.34%. Comparing base (5322fe6) to head (dcfe15e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1226   +/-   ##
=======================================
  Coverage   91.34%   91.34%           
=======================================
  Files          58       58           
  Lines        2959     2959           
=======================================
  Hits         2703     2703           
  Misses        256      256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjlittle bjlittle merged commit baabb88 into main Nov 25, 2024
23 checks passed
@bjlittle bjlittle deleted the fix-linkcheck-redirects branch November 25, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Auto-labelled for bug/*, fix/* and patch/* branches type: documentation Auto-labelled for doc/* and docs/* branches type: examples Auto-labelled for ex/*, example/* and examples/* branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant