Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Updates accessibility statement #3145

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Chore: Updates accessibility statement #3145

merged 2 commits into from
Nov 18, 2024

Conversation

TheDancingClown
Copy link
Contributor

📝 A short description of the changes

  • Updates accessibility statement to reflect WCAG 2.2 AA testing
  • Fixes routing for accessibility statement for users. When users are logged in the url is /dashboard so they were being shown the Accessibility Statement for admins. A check for current_user is therefore included.

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

  • None

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots

Screenshot 2024-11-18 at 13 15 08

phil-l-brockwell
phil-l-brockwell reviewed Nov 18, 2024
View reviewed changes
app/views/layouts/application.html.slim
@@ -103,9 +103,9 @@ title = content_for?(:title) ? "#{'Appraisal view of ' if admin_in_read_only_mod
li.govuk-footer__inline-list-item
= link_to "Privacy Statement", privacy_path, class: 'govuk-footer__link'
li.govuk-footer__inline-list-item
- if request.path.include?("/users")
- if request.path.include?("/users") || current_user
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wont this stop us falling into the else when we need to?

@phil-l-brockwell phil-l-brockwell merged commit 03e62ef into main Nov 18, 2024
12 checks passed
@phil-l-brockwell phil-l-brockwell deleted the accessibility-update branch November 18, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-l-brockwell phil-l-brockwell phil-l-brockwell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheDancingClown @phil-l-brockwell