-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-7918] Design Feedback and other cleanup #136
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,9 @@ | ||
{ | ||
"collapsed": true, | ||
"label": "Create", | ||
"link": { | ||
"type": "generated-index", | ||
"description": "Common patterns for account creation forms" | ||
}, | ||
"collapsed": false | ||
"position": 5 | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,9 @@ | ||
{ | ||
"collapsed": true, | ||
"label": "Identity", | ||
"link": { | ||
"type": "generated-index", | ||
"description": "Common patterns for identity forms" | ||
}, | ||
"collapsed": false | ||
"position": 2 | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
{ | ||
"collapsed": false, | ||
"label": "Login", | ||
"position": 1, | ||
"link": { | ||
"type": "generated-index", | ||
"description": "Common patterns for login forms" | ||
}, | ||
"collapsed": false | ||
"position": 1 | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,9 @@ | ||
{ | ||
"collapsed": true, | ||
"label": "Payment", | ||
"link": { | ||
"type": "generated-index", | ||
"description": "Common patterns for payment forms" | ||
}, | ||
"collapsed": false | ||
"position": 3 | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,9 @@ | ||
{ | ||
"collapsed": true, | ||
"label": "Search", | ||
"link": { | ||
"type": "generated-index", | ||
"description": "Common patterns for search inputs" | ||
}, | ||
"collapsed": false | ||
"position": 4 | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,9 @@ | ||
{ | ||
"collapsed": true, | ||
"label": "Update", | ||
"link": { | ||
"type": "generated-index", | ||
"description": "Common patterns for authentication update forms" | ||
}, | ||
"collapsed": false | ||
"position": 6 | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
--- | ||
title: Intro | ||
displayed_sidebar: formsSidebar | ||
--- | ||
|
||
# Let's test the web! | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,33 +1,9 @@ | ||
/** | ||
* Creating a sidebar enables you to: | ||
- create an ordered group of docs | ||
- render a sidebar for each doc of that group | ||
- provide next/previous navigation | ||
|
||
The sidebars can be generated from the filesystem, or explicitly defined here. | ||
|
||
Create as many sidebars as you want. | ||
*/ | ||
|
||
// @ts-check | ||
|
||
/** @type {import('@docusaurus/plugin-content-docs').SidebarsConfig} */ | ||
const sidebars = { | ||
// By default, Docusaurus generates a sidebar from the docs folder structure | ||
formsSidebar: [{ type: "autogenerated", dirName: "forms" }], | ||
|
||
// But you can create a sidebar manually | ||
/* | ||
tutorialSidebar: [ | ||
'intro', | ||
'hello', | ||
{ | ||
type: 'category', | ||
label: 'Tutorial', | ||
items: ['tutorial-basics/create-a-document'], | ||
}, | ||
], | ||
*/ | ||
}; | ||
|
||
module.exports = sidebars; |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,25 +59,18 @@ | |
--docusaurus-highlighted-code-line-bg: rgba(0, 0, 0, 0.3); | ||
} | ||
|
||
.theme-doc-markdown > header:first-of-type details > summary { | ||
list-style: none; | ||
} | ||
.theme-doc-markdown > header:first-of-type details > summary::after { | ||
font-size: 24px; | ||
content: " ▸"; | ||
} | ||
.theme-doc-markdown > header:first-of-type details[open] > summary::after { | ||
font-size: 24px; | ||
content: " ▾"; | ||
} | ||
Comment on lines
-62
to
-72
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Leftover styling from 26a4ff2 |
||
|
||
.theme-doc-markdown > header:first-of-type h1:first-of-type { | ||
display: inline-block; | ||
cursor: pointer; | ||
font-size: 24px; | ||
margin-bottom: 5px; | ||
} | ||
|
||
main [class^="docItemCol_"], | ||
main [class*=" docItemCol_"] { | ||
margin: auto; | ||
} | ||
|
||
select, | ||
input:not([type]), /* text type is stripped from built html */ | ||
input[type="url"], | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No longer needed thanks to facebook/docusaurus#10061 in v3.3.0 |
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussion on both facebook/docusaurus#9665 and facebook/docusaurus#9688 offers some workarounds, but they didn't work well here without a lot of extra refactors which I opted not to get into here.