Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sm/test-ruby-language-bindings #1084

Draft
wants to merge 6 commits into
base: test-python-language-bindings
Choose a base branch
from

Conversation

MGibson1
Copy link
Member

📔 Objective

Ruby language binding end to end tests

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Sep 25, 2024

Logo
Checkmarx One – Scan Summary & Detailsdfd752f2-d38a-40fb-a74c-adcb7e859ea4

New Issues

Severity Issue Source File / Package Checkmarx Insight
HIGH Passwords And Secrets - Generic Token /language-tests.yml: 114 Query to find passwords and secrets in infrastructure code.

Fixed Issues

Severity Issue Source File / Package
HIGH Passwords And Secrets - Generic Token /language-tests.yml: 111

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.27%. Comparing base (d923039) to head (b5e2593).

Additional details and impacted files
@@                      Coverage Diff                       @@
##           test-python-language-bindings    #1084   +/-   ##
==============================================================
  Coverage                          58.27%   58.27%           
==============================================================
  Files                                192      192           
  Lines                              13486    13486           
==============================================================
  Hits                                7859     7859           
  Misses                              5627     5627           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MGibson1 MGibson1 force-pushed the sm/test-ruby-language-bindings branch from f4111e8 to c9b8668 Compare September 26, 2024 13:04
@MGibson1 MGibson1 force-pushed the test-python-language-bindings branch from dc0b652 to cb58c28 Compare September 26, 2024 13:35
@MGibson1 MGibson1 force-pushed the sm/test-ruby-language-bindings branch from c8a565f to ff665e8 Compare September 26, 2024 13:35
@MGibson1 MGibson1 force-pushed the test-python-language-bindings branch 2 times, most recently from 059aedc to 594d567 Compare September 26, 2024 13:48
@MGibson1 MGibson1 force-pushed the sm/test-ruby-language-bindings branch 3 times, most recently from efdbcb4 to 94cfc7b Compare September 26, 2024 15:47
@MGibson1 MGibson1 force-pushed the test-python-language-bindings branch from b8b2d7a to 5bcba8c Compare September 26, 2024 16:09
@MGibson1 MGibson1 force-pushed the sm/test-ruby-language-bindings branch 2 times, most recently from f2485b3 to 989daee Compare September 26, 2024 16:12
@MGibson1 MGibson1 force-pushed the test-python-language-bindings branch 2 times, most recently from 0779656 to 2851fac Compare September 26, 2024 16:55
@MGibson1 MGibson1 force-pushed the sm/test-ruby-language-bindings branch from 989daee to b5e2593 Compare September 26, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant