Merge branch 'release/3.2.0'

Classes/BITHockeyManager.h

@@ -185,7 +185,6 @@
  Returns the BITFeedbackManager instance initialized by BITHockeyManager
  
  @see configureWithIdentifier:delegate:
- @see configureWithBetaIdentifier:liveIdentifier:delegate:
  @see startManager
  @see disableFeedbackManager
  */
@@ -213,39 +212,81 @@
 
 /** Set the userid that should used in the SDK components
  
- Right now this is used by the `BITCrashMananger` to attach to a crash report and `BITFeedbackManager`.
+ Right now this is used by the `BITCrashManager` to attach to a crash report.
+ `BITFeedbackManager` uses it too for assigning the user to a discussion thread.
  
- Note: the value is persisted in the keychain! To remove old values, call this setter with a `nil` value.
+ The value can be set at any time and will be stored in the keychain on the current
+ device only! To delete the value from the keychain set the value to `nil`.
+ 
+ This property is optional and can be used as an alternative to the delegate. If you
+ want to define specific data for each component, use the delegate instead which does
+ overwrite the values set by this property.
+ 
+ @warning When returning a non nil value, crash reports are not anonymous any more
+ and the crash alerts will not show the word "anonymous"!
+ 
+ @warning This property needs to be set before calling `startManager` to be considered
+ for being added to crash reports as meta data.
  
  @see [BITHockeyManagerDelegate userIDForHockeyManager:componentManager:]
  @see setUserName:
  @see setUserEmail:
+ 
+ @param userID NSString value for the userID
  */
 - (void)setUserID:(NSString *)userID;
 
 
 /** Set the user name that should used in the SDK components
  
- Right now this is used by the `BITCrashMananger` to attach to a crash report and `BITFeedbackManager`.
+ Right now this is used by the `BITCrashManager` to attach to a crash report.
+ `BITFeedbackManager` uses it too for assigning the user to a discussion thread.
+ 
+ The value can be set at any time and will be stored in the keychain on the current
+ device only! To delete the value from the keychain set the value to `nil`.
+ 
+ This property is optional and can be used as an alternative to the delegate. If you
+ want to define specific data for each component, use the delegate instead which does
+ overwrite the values set by this property.
  
- Note: the value is persisted in the keychain! To remove old values, call this setter with a `nil` value.
+ @warning When returning a non nil value, crash reports are not anonymous any more
+ and the crash alerts will not show the word "anonymous"!
+ 
+ @warning This property needs to be set before calling `startManager` to be considered
+ for being added to crash reports as meta data.
 
  @see [BITHockeyManagerDelegate userNameForHockeyManager:componentManager:]
  @see setUserID:
  @see setUserEmail:
+ 
+ @param userName NSString value for the userName
  */
 - (void)setUserName:(NSString *)userName;
 
 
 /** Set the users email address that should used in the SDK components
  
- Right now this is used by the `BITCrashMananger` to attach to a crash report and `BITFeedbackManager`.
+ Right now this is used by the `BITCrashManager` to attach to a crash report.
+ `BITFeedbackManager` uses it too for assigning the user to a discussion thread.
+ 
+ The value can be set at any time and will be stored in the keychain on the current
+ device only! To delete the value from the keychain set the value to `nil`.
  
- Note: the value is persisted in the keychain! To remove old values, call this setter with a `nil` value.
+ This property is optional and can be used as an alternative to the delegate. If you
+ want to define specific data for each component, use the delegate instead which does
+ overwrite the values set by this property.
+ 
+ @warning When returning a non nil value, crash reports are not anonymous any more
+ and the crash alerts will not show the word "anonymous"!
+ 
+ @warning This property needs to be set before calling `startManager` to be considered
+ for being added to crash reports as meta data.
 
  @see [BITHockeyManagerDelegate userEmailForHockeyManager:componentManager:]
  @see setUserID:
  @see setUserName:
+ 
+ @param userEmail NSString value for the userEmail
  */
 - (void)setUserEmail:(NSString *)userEmail;
 

Classes/BITHockeyManager.m

@@ -40,9 +40,6 @@ @implementation BITHockeyManager {
 
   BOOL _startManagerIsInvoked;
 
-  NSInteger         _statusCode;
-  NSURLConnection   *_urlConnection;
-
   BITHockeyAppClient *_hockeyAppClient;
 }
 

Classes/CrashReporting/BITCrashDetails.h

@@ -93,26 +93,4 @@
  */
 @property (nonatomic, readonly, strong) NSString *appBuild;
 
-/**
- Indicates if the app was killed while being in foreground from the iOS
- 
- If `[BITCrashManager enableAppNotTerminatingCleanlyDetection]` is enabled, use this on startup
- to check if the app starts the first time after it was killed by iOS in the previous session.
- 
- This can happen if it consumed too much memory or the watchdog killed the app because it
- took too long to startup or blocks the main thread for too long, or other reasons. See Apple
- documentation: https://developer.apple.com/library/ios/qa/qa1693/_index.html
- 
- See `[BITCrashManager enableAppNotTerminatingCleanlyDetection]` for more details about which kind of kills can be detected.
- 
- @warning This property only has a correct value, once `[BITHockeyManager startManager]` was
- invoked! In addition, it is automatically disabled while a debugger session is active!
- 
- @see `[BITCrashManager enableAppNotTerminatingCleanlyDetection]`
- @see `[BITCrashManager didReceiveMemoryWarningInLastSession]`
- 
- @return YES if the details represent an app kill instead of a crash
- */
-- (BOOL)isAppKill;
-
 @end

Classes/CrashReporting/BITCrashDetails.m

@@ -29,8 +29,6 @@
 #import "BITCrashDetails.h"
 #import "BITCrashDetailsPrivate.h"
 
-NSString *const kBITCrashKillSignal = @"SIGKILL";
-
 @implementation BITCrashDetails
 
 - (instancetype)initWithIncidentIdentifier:(NSString *)incidentIdentifier
@@ -61,13 +59,4 @@ - (instancetype)initWithIncidentIdentifier:(NSString *)incidentIdentifier
   return self;
 }
 
-- (BOOL)isAppKill {
-  BOOL result = NO;
-
-  if (_signal && [[_signal uppercaseString] isEqualToString:kBITCrashKillSignal])
-    result = YES;
-
-  return result;
-}
-
 @end

Classes/CrashReporting/BITCrashDetailsPrivate.h

@@ -28,8 +28,6 @@
 
 #import <HockeySDK/HockeySDK.h>
 
-extern NSString *const __attribute__((unused)) kBITCrashKillSignal;
-
 @interface BITCrashDetails () {
 
 }

Classes/CrashReporting/BITCrashManager.h

@@ -174,8 +174,6 @@ typedef NS_ENUM(NSUInteger, BITCrashManagerUserInput) {
  *  Mach-based handling should _NOT_ be used when a debugger is attached. The SDK will not
  *  enable catching exceptions if the app is started with the debugger running. If you attach
  *  the debugger during runtime, this may cause issues if it is not disabled!
- *
- * @deprecated Mach Exception Handler is now enabled by default!
  */
 @property (nonatomic, assign, getter=isMachExceptionHandlerDisabled) BOOL disableMachExceptionHandler;