Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing import methods #114

Closed
wants to merge 1 commit into from
Closed

Changing import methods #114

wants to merge 1 commit into from

Conversation

grctest
Copy link
Contributor

@grctest grctest commented May 31, 2023

The CJS format of importing packages like require("safe-buffer").Buffer causes issues in Tauri.

Proposing switching from require to using import methods more extensively.

All tests pass, but I've not yet been able to test if it resolves the error in tauri.

If this won't work, then perhaps we replace safe-buffer altogether? feross/safe-buffer#32

Avoid require not found errors in browser
@grctest
Copy link
Contributor Author

grctest commented Jun 2, 2023

I've switched from tauri to electron, so the issue which led to this PR idea is now closed. Some may run into this in the future though

@grctest grctest closed this Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant