feat: Add UnVerified role removal after verification #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nihalxkumar
commented
Oct 30, 2024
nihalxkumar
commented
- Add functionality to remove UnVerified role after successful verification
- Rename CodeModal to OTPModal
- Add section comments in OTPModal
- Fix one missed out change from last commit of renaming "Enter Code" to "Enter OTP"
nihalxkumar
added
the
enhancement
GitHub Codespaces
sattwyk
requested changes
Nov 5, 2024
There was a problem hiding this comment.
Please change the order of actions when handling roles. First, remove the "Unverified" role and then add the "Verified" role. This way, you avoid the situation where the "Verified" role is added but the "Unverified" role has not been removed. Additionally, include a check to see if the user has the "Unverified" role before making any changes.
sattwyk
reviewed
Nov 5, 2024
sattwyk
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.