Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix + refactor: fixed textui bug + Improved code style, respecting ESLint rules #759

Merged
merged 23 commits into from
Jul 31, 2024

Conversation

bitpredator
Copy link
Owner

@bitpredator bitpredator commented Jul 29, 2024

Fixes #747

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Discord username (if different from GitHub):

@bitpredator bitpredator changed the title Dev fix + refactor: fixed textui bug + Improved code style, respecting ESLint rules Jul 29, 2024
}
const $notification = $(document.createElement('div'));
$notification.addClass('notification').addClass(data.type);
$notification.html(data.text);

Check failure

Code scanning / CodeQL

Client-side cross-site scripting High

Cross-site scripting vulnerability due to
user-provided value
.
$notification.html(data.text);
const $notification = $(notifs[data.id]);
$notification.addClass('notification').addClass(data.type);
$notification.html(data.text);

Check failure

Code scanning / CodeQL

Client-side cross-site scripting High

Cross-site scripting vulnerability due to
user-provided value
.

if (data.poundCost != undefined) {
$('.content .vehicle-list').html(
getVehicles(data.locales, data.vehiclesList, data.poundCost),

Check failure

Code scanning / CodeQL

Client-side cross-site scripting High

Cross-site scripting vulnerability due to
user-provided value
.
}
else {
$('.content .vehicle-list').html(
getVehicles(data.locales, data.vehiclesList),

Check failure

Code scanning / CodeQL

Client-side cross-site scripting High

Cross-site scripting vulnerability due to
user-provided value
.
if (data.poundCost) $('#container').data('poundcost', data.poundCost);

$('.impounded_content .vehicle-list').html(
getImpoundedVehicles(data.locales, data.vehiclesImpoundedList),

Check failure

Code scanning / CodeQL

Client-side cross-site scripting High

Cross-site scripting vulnerability due to
user-provided value
.
@bitpredator bitpredator self-assigned this Jul 31, 2024
Comment on lines +65 to +67
$('.vehicle-listing').html(function(_i, text) {
return text.replace('Model', data.locales.veh_model);
});

Check failure

Code scanning / CodeQL

Client-side cross-site scripting High

Cross-site scripting vulnerability due to
user-provided value
.
Comment on lines +68 to +70
$('.vehicle-listing').html(function(_i, text) {
return text.replace('Plate', data.locales.veh_plate);
});

Check failure

Code scanning / CodeQL

Client-side cross-site scripting High

Cross-site scripting vulnerability due to
user-provided value
.
Comment on lines +71 to +73
$('.vehicle-listing').html(function(_i, text) {
return text.replace('Condition', data.locales.veh_condition);
});

Check failure

Code scanning / CodeQL

Client-side cross-site scripting High

Cross-site scripting vulnerability due to
user-provided value
.
@bitpredator bitpredator merged commit 5097360 into main Jul 31, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

showroom implementation
1 participant