Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix memory leak #176

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Feature/fix memory leak #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb5acba
fix: prevent memory leak by de-registering event handlers
martinstark Mar 29, 2023
1789e98
Add changelog
dweinber Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Fixed

- Parsing non-Yospace ID3 tags and passing those to the Yospace SDK
- Small memory leak where player listeners were not detached

## [2.5.0] - 2024-07-10

Expand Down
4 changes: 2 additions & 2 deletions src/ts/InternalBitmovinYospacePlayer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1193,8 +1193,8 @@ export class InternalBitmovinYospacePlayer implements BitmovinYospacePlayerAPI {
this.player.off(this.player.exports.PlayerEvent.StallStarted, this.onStallStarted);
this.player.off(this.player.exports.PlayerEvent.StallEnded, this.onStallEnded);

this.player.on(this.player.exports.PlayerEvent.Muted, this.onMuted);
this.player.on(this.player.exports.PlayerEvent.Unmuted, this.onUnmuted);
this.player.off(this.player.exports.PlayerEvent.Muted, this.onMuted);
this.player.off(this.player.exports.PlayerEvent.Unmuted, this.onUnmuted);

// To support ads in live streams we need to track metadata events
this.player.off(this.player.exports.PlayerEvent.Metadata, this.onMetaData);
Expand Down
Loading