Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-yospace id3tags gracefully #174

Merged
merged 45 commits into from
Jul 12, 2024

Conversation

dweinber
Copy link
Member

@dweinber dweinber commented Jun 18, 2024

Description

The integration tried to parse non-yospace ID3 tags, and passed them to the yospace SDK, which led to errors in the console. This PR stops doing that. If an ID3 tag doesn't have the standard yospace tags the SDK expects, the ID3 tag will be discarded.

This is based on #171 and should be merged after that PR.

Checklist (for PR submitter and reviewers)

  • CHANGELOG entry

martinstark and others added 30 commits March 21, 2024 14:40
(cherry picked from commit 5fc19b3)
This fixes an issue with ads not being
properly deactivated when seeked past
@martinstark martinstark changed the base branch from develop to feat/ad-holiday June 18, 2024 08:44
@martinstark martinstark changed the base branch from feat/ad-holiday to develop June 18, 2024 08:45
dweinber added 3 commits June 18, 2024 10:57
…s-gracefully

 Conflicts:
	CHANGELOG.md
	src/ts/InternalBitmovinYospacePlayer.ts
…-yospace-id3tags-gracefully

 Conflicts:
	CHANGELOG.md
@dweinber dweinber merged commit da2ca94 into develop Jul 12, 2024
3 checks passed
@dweinber dweinber deleted the feature/handle-non-yospace-id3tags-gracefully branch July 12, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants