Skip to content

Commit

Permalink
Merge pull request #182 from bitmovin/feature/fix-adbreak-skipping-wi…
Browse files Browse the repository at this point in the history
…th-ad-immunity

Fix AdBreak skipping with ad immunity
  • Loading branch information
dweinber authored Oct 30, 2024
2 parents 0d8fb5e + 8dfd7b0 commit 47475ce
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

- Support for the `DVRLIVE` PlaybackMode to not rely on Metadata parsing for live streams anymore

### Fixed

- Wrong playback position after skipping over ad breaks using ad immunity

## [2.7.1] - 2024-10-03

### Fixed
Expand Down
4 changes: 2 additions & 2 deletions src/ts/InternalBitmovinYospacePlayer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ export class InternalBitmovinYospacePlayer implements BitmovinYospacePlayerAPI {
const properties = new SessionProperties();
properties.setUserAgent(navigator.userAgent);

if (this.yospaceConfig.debug || this.yospaceConfig.debugYospaceSdk) {
if (this.yospaceConfig.debugYospaceSdk) {
YoLog.setDebugFlags(DebugFlags.DEBUG_ALL);
}

Expand Down Expand Up @@ -1237,7 +1237,7 @@ export class InternalBitmovinYospacePlayer implements BitmovinYospacePlayerAPI {
this.player.seek(this.cachedSeekTarget, 'yospace-ad-skipping');
this.cachedSeekTarget = null;
} else {
this.seek(seekTarget);
this.player.seek(seekTarget, 'yospace-ad-skipping');
}
}

Expand Down

0 comments on commit 47475ce

Please sign in to comment.