Merge pull request #176 from bitmovin/feature/fix-memory-leak

Fix memory leak
bitmovin · Jul 12, 2024 · 2ac5547 · 2ac5547
2 parents 181fe2a + 1789e98
commit 2ac5547
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ### Fixed
 
 - Parsing non-Yospace ID3 tags and passing those to the Yospace SDK
+- Small memory leak where player listeners were not detached
 
 ## [2.5.0] - 2024-07-10
 

diff --git a/src/ts/InternalBitmovinYospacePlayer.ts b/src/ts/InternalBitmovinYospacePlayer.ts
@@ -1193,8 +1193,8 @@ export class InternalBitmovinYospacePlayer implements BitmovinYospacePlayerAPI {
     this.player.off(this.player.exports.PlayerEvent.StallStarted, this.onStallStarted);
     this.player.off(this.player.exports.PlayerEvent.StallEnded, this.onStallEnded);
 
-    this.player.on(this.player.exports.PlayerEvent.Muted, this.onMuted);
-    this.player.on(this.player.exports.PlayerEvent.Unmuted, this.onUnmuted);
+    this.player.off(this.player.exports.PlayerEvent.Muted, this.onMuted);
+    this.player.off(this.player.exports.PlayerEvent.Unmuted, this.onUnmuted);
 
     // To support ads in live streams we need to track metadata events
     this.player.off(this.player.exports.PlayerEvent.Metadata, this.onMetaData);