-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Debug Logging #568
Conversation
We should merge only after iOS SDK version |
Co-authored-by: Roland Kákonyi <[email protected]>
Co-authored-by: Roland Kákonyi <[email protected]>
Co-authored-by: Roland Kákonyi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes and testing looks good!
DebugConfig._isDebugEnabled = value; | ||
await DebugModule.setDebugLoggingEnabled(value); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TypeDoc note: I've discovered we can use @defaultValue 😮
Description
Debug logging provides detailed information primarily for debugging purposes, helping to diagnose problems and trace the flow of execution within the Player.
Changes
New static APIs to check and set whether debug logging is enabled:
isDebugLoggingEnabled
setDebugLogging(value: boolean)
Internally, this has been handled by adding a new module, because this is not a config like the others since it is static/global.
Test and Basic Usage
Important
For iOS, Use player version
3.77.3-a.1
or newerAdd the following to BasicPlayback:
// other imports ... import { useTVGestures } from '../hooks'; + DebugConfig.setDebugLogging(true); // Add it right after the imports
Can also leverage a player event to test the flag:
Checklist
CHANGELOG
entry