Expose TweaksConfig.forceReuseVideoCodecReasons from Android
#561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eVideoCodecReasons
krocard
requested changes
Nov 14, 2024
Comment on lines
204
to
212
| val mutableSet = mutableSetOf<ForceReuseVideoCodecReason>() | ||
| for (item in it) { | ||
| val reason = item?.forceReuseVideoCodecReason() | ||
| if (reason != null) { | ||
| mutableSet.add(reason) | ||
| } | ||
| } | ||
| forceReuseVideoCodecReasons = mutableSet | ||
| } |
There was a problem hiding this comment.
Suggested change
| val mutableSet = mutableSetOf<ForceReuseVideoCodecReason>() | |
| for (item in it) { | |
| val reason = item?.forceReuseVideoCodecReason() | |
| if (reason != null) { | |
| mutableSet.add(reason) | |
| } | |
| } | |
| forceReuseVideoCodecReasons = mutableSet | |
| } | |
| forceReuseVideoCodecReasons = it.mapNotNull(String::toForceReuseVideoCodecReason).toSet() |
There was a problem hiding this comment.
Probably also a toSet() needs to be added.
| /** | ||
| * When switching between video formats (eg: adapting between video qualities) the codec might be recreated due to several reasons. | ||
| * This behaviour can cause brief black screens when switching between video qualities as codec recreation can be slow. | ||
| * |
There was a problem hiding this comment.
Documentation was incomplete.
Suggested change
| * | |
| * | |
| * If a device is know to support video format changes and keep the current decoder without issues, | |
| * this set can be filled with multiple `ForceReuseVideoCodecReason` and avoid the black screen. | |
| * |
| /** | ||
| * Converts any JS string into an `AdSourceType` enum value. | ||
| */ | ||
| private fun String.forceReuseVideoCodecReason(): ForceReuseVideoCodecReason? = when (this) { |
There was a problem hiding this comment.
Conversion function are prefixed by to:
Suggested change
| private fun String.forceReuseVideoCodecReason(): ForceReuseVideoCodecReason? = when (this) { | |
| private fun String.toForceReuseVideoCodecReason(): ForceReuseVideoCodecReason? = when (this) { |
| @@ -167,6 +168,16 @@ fun ReadableMap.toStyleConfig(): StyleConfig = StyleConfig().apply { | |||
| withString("scalingMode") { scalingMode = ScalingMode.valueOf(it) } | |||
| } | |||
|
|
|||
| /** | |||
| * Converts any JS string into an `AdSourceType` enum value. | |||
There was a problem hiding this comment.
Suggested change
| * Converts any JS string into an `AdSourceType` enum value. | |
| * Converts any JS string into an `ForceReuseVideoCodecReason` enum value. |
matamegger
requested changes
Nov 14, 2024
android/src/main/java/com/bitmovin/player/reactnative/converter/JsonConverter.kt
Outdated
Show resolved
Hide resolved
Comment on lines
204
to
212
| val mutableSet = mutableSetOf<ForceReuseVideoCodecReason>() | ||
| for (item in it) { | ||
| val reason = item?.forceReuseVideoCodecReason() | ||
| if (reason != null) { | ||
| mutableSet.add(reason) | ||
| } | ||
| } | ||
| forceReuseVideoCodecReasons = mutableSet | ||
| } |
There was a problem hiding this comment.
Probably also a toSet() needs to be added.
matamegger
changed the title
TweaksConfig.forceReuseVideoCodecReasons from Android
|
Thanks for the reviews, I'll pick this up tomorrow. |
…-tweaksConfig-forceReuseVideoCodecReasons
matamegger
approved these changes
Nov 15, 2024
krocard
approved these changes
Nov 15, 2024
Co-authored-by: Matthias Tamegger <[email protected]>
strangesource
deleted the
PRN-147/expose-tweaksConfig-forceReuseVideoCodecReasons
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expose Android SDKs TweaksConfig.forceReuseVideoCodecReasons
Changes
Checklist
CHANGELOGentry