Include the possibility to define uiManagerFactoryFunction #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zigavehovec
changed the title
…i-for-react-native-android-tv-os # Conflicts: # CHANGELOG.md # android/build.gradle
|
In an ideal world we would have a tv sample, maybe we can add one in a follow up ticked if we have time. |
Co-authored-by: Lukas Knoch-Girstmair <[email protected]>
strangesource
approved these changes
Oct 30, 2024
…-native-android-tv-os # Conflicts: # CHANGELOG.md
zigavehovec
deleted the
PRN-106/include-smart-tv-ui-for-react-native-android-tv-os
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Native SDKs support defining
uiManagerFactoryFunctionvia:On Android this is an important use case, since the default small screen UI doesn't support TV spatial navigation out of the box.
For the public API in this PR I tried to keep it close to what we have on Android.
Right now the sample is integrated in the basic playback sample, meaning that other samples won't have the TV spatial navigation enabled by default. I'm a bit unsure if we should just add it to all the samples, as I would assume this should be enough.
Changes
Checklist
CHANGELOGentry