Android: support Background Playback #541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
123mpozzi
commented
Oct 23, 2024
Comment on lines
-57
to
-62
| * { | ||
| * playbackConfig: { | ||
| * isBackgroundPlaybackEnabled: true, | ||
| * } | ||
| * }) | ||
| * }, | ||
| * }); | ||
| * ``` | ||
| * @platform iOS, tvOS |
There was a problem hiding this comment.
playbackConfig was missing from here
123mpozzi
commented
Oct 23, 2024
Comment on lines
-50
to
+54
| * On tvOS, background playback is only supported for audio-only content. | ||
| * | ||
| * Default is `false`. | ||
| * | ||
| * @note | ||
| * On tvOS, background playback is only supported for audio-only content. | ||
| * |
There was a problem hiding this comment.
Moved the tvOS-specific paragraph into a note
1 task
|
Closing as this is part of #539 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support background playback on Android as well
Changes
playerConfig.playbackConfig.isBackgroundEnabledon Android as wellTesting
Please, if possible, do some manual testing on a physical device 🙏
Things to look for
Background Playback (use the new sample)
Activity lifecycle
Checklist
CHANGELOGentry