-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS: support Media Controls #532
iOS: support Media Controls #532
Conversation
As I'll use a base branch and 2 separate PRs instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait until we know how the Android part will look like before proceeding here. If the introduced config will only be available for iOS, I would prefer to match the naming to what we have on iOS
* wherever current media information typically appears, such as the lock screen | ||
* and inside the control center. | ||
*/ | ||
export interface LockScreenControlConfig { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this will be most likely only for iOS, would it make sense to use NowPlayingConfig
as a name to match what we have in iOS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the config will also be available for Android, I would keep the naming as LockScreenControlConfig
1c7cfe2
into
feature/base-enable-lock-screen-controls
Description
Introduce the lock-screen control config!
Use it to make the system display the current media information on the lock-screen, in notifications, and within the control-center
PR-planning
Both will be merged together on a base branch
Overview Pics
Changes
Introduce
LockScreenControlConfig
isEnabled
to enable/disable the featureDeprecate
TweaksConfig.updatesNowPlayingInfoCenter
Test
Manually test the integration being turned on/off by adding the new config into a sample (e.g. BasicPlayback):
Checklist
CHANGELOG
entry