Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve start release workflow #305

Merged
merged 10 commits into from
Dec 18, 2023
Merged

Improve start release workflow #305

merged 10 commits into from
Dec 18, 2023

Conversation

rolandkakonyi
Copy link
Contributor

@rolandkakonyi rolandkakonyi commented Oct 20, 2023 •
edited
Loading

Description

  1. We don't utilize a CocoaPods cache, which makes the release process slower than needed
  2. One might miss the notification about a new PR without explicitly assigning a reviewer for the release PR
  3. There is no easy way to test the release workflow

Changes

  1. Added the same cache solution we use for ci.yml workflow
  2. Assigning the user triggering the release process explicitly as reviewer on the release PR
  3. Added new option for dry_run, to enable testing this workflow

Successful run (with dry_run enabled): https://github.com/bitmovin/bitmovin-player-react-native/actions/runs/6588544853

Runtime went from 6 minutes to 3.5 minutes.

Checklist

  • 🗒 CHANGELOG entry - not applicable

@rolandkakonyi rolandkakonyi self-assigned this Oct 20, 2023
@rolandkakonyi rolandkakonyi marked this pull request as ready for review December 15, 2023 12:43
@rolandkakonyi rolandkakonyi force-pushed the improve-start-release-workflow branch from 858b6c8 to 2d85db8 Compare December 15, 2023 13:30
zigavehovec
zigavehovec approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@zigavehovec zigavehovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@zigavehovec zigavehovec mentioned this pull request Dec 18, 2023
Merged
1 task
@rolandkakonyi rolandkakonyi merged commit fe684d5 into development Dec 18, 2023
25 of 26 checks passed
@rolandkakonyi rolandkakonyi deleted the improve-start-release-workflow branch December 18, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zigavehovec zigavehovec zigavehovec approved these changes

Assignees

@rolandkakonyi rolandkakonyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rolandkakonyi @zigavehovec