Implement BufferAPI via Player.buffer
#298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
123mpozzi
changed the title
Player.buffer namespace
They will be put in a different docs-centric PR
…into bufferapi-namespace
Co-authored-by: Roland Kákonyi <[email protected]>
…ad' into bufferapi-namespace
android/src/main/java/com/bitmovin/player/reactnative/BufferModule.kt
Outdated
Show resolved
Hide resolved
…ngs instead of Int
On iOS it should not be needed as the value is just passed through because iOS just support combined audio+video MediaType
We should explain why that object is there and its importance
zigavehovec
reviewed
Oct 23, 2023
as JSON handlers shouldn't handle logic, and this forces the kotlin compiler to tell us to cover every case (so it is safer to handle new cases added in the future)
123mpozzi
changed the title
Player.buffer namespacePlayer.buffer
123mpozzi
changed the title
Player.bufferPlayer.buffer
We should take advantage of compilers to get compile time errors when a new value isn't handled instead of using default.
123mpozzi
changed the title
Player.bufferPlayer.buffer
rolandkakonyi
approved these changes
Oct 25, 2023
zigavehovec
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement Buffer APIs to configure buffer settings and to query the current buffer state.
Changes
Player.buffernamespaceBufferApiBufferType,BufferLevel, andMediaTypeTesting
Apply this patch, open Basic Playback, and look at the logs on Metro:
patch.diff.txt
Checks
levelupdates correctlytargetLevelis set to300mediatype and buffertypeserialise correctlyChecklist
CHANGELOGentry