Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement BufferAPI: BufferConfig #291

Merged
merged 12 commits into from
Oct 17, 2023
Merged

Implement BufferAPI: BufferConfig #291

merged 12 commits into from
Oct 17, 2023

Conversation

123mpozzi
Copy link
Contributor

@123mpozzi 123mpozzi commented Oct 16, 2023 •
edited
Loading

Description

Implement BufferConfig to control player buffer depth

Changes

  • Add BufferMediaTypeConfig, BufferConfig
  • Extend PlayerConfig interface to include a bufferConfig property
  • Add jsdoc links to mentioned objects inside PlayerConfig

Checklist

  • 🗒 CHANGELOG entry

@123mpozzi 123mpozzi self-assigned this Oct 16, 2023
@123mpozzi 123mpozzi changed the title Bufferapi: implement types and config Implement BufferAPI: types and config Oct 16, 2023
@123mpozzi 123mpozzi marked this pull request as ready for review October 17, 2023 08:18
rolandkakonyi
rolandkakonyi reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@rolandkakonyi rolandkakonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

I will manually test it next.

CHANGELOG.md Outdated Show resolved Hide resolved
src/player.ts Outdated Show resolved Hide resolved
@123mpozzi 123mpozzi changed the title Implement BufferAPI: types and config Implement BufferAPI: BufferConfig Oct 17, 2023
@rolandkakonyi rolandkakonyi self-requested a review October 17, 2023 11:12
rolandkakonyi
rolandkakonyi approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@rolandkakonyi rolandkakonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing looks good too!

matamegger
matamegger approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@matamegger matamegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@123mpozzi 123mpozzi merged commit 7b9b835 into development Oct 17, 2023
6 checks passed
@123mpozzi 123mpozzi deleted the bufferapi-types-and-config branch October 17, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matamegger matamegger matamegger approved these changes

@rolandkakonyi rolandkakonyi rolandkakonyi approved these changes

Assignees

@123mpozzi 123mpozzi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@123mpozzi @rolandkakonyi @matamegger