Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing API docs #284

Merged
merged 10 commits into from
Oct 11, 2023
Merged

Add missing API docs #284

merged 10 commits into from
Oct 11, 2023

Conversation

rolandkakonyi
Copy link
Contributor

@rolandkakonyi rolandkakonyi commented Oct 10, 2023

Description

We miss documentation for some of our public API.

Changes

Added missing documentation.

Checklist

  • 🗒 CHANGELOG entry - not applicable

@rolandkakonyi rolandkakonyi self-assigned this Oct 10, 2023
@rolandkakonyi rolandkakonyi marked this pull request as ready for review October 10, 2023 09:37
Copy link
Contributor

@strangesource strangesource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements. Just some minor comments from my side.

src/advertising.ts Show resolved Hide resolved
src/advertising.ts Outdated Show resolved Hide resolved
src/components/PlayerView/events.ts Outdated Show resolved Hide resolved
src/components/PlayerView/index.tsx Outdated Show resolved Hide resolved
src/events.ts Outdated Show resolved Hide resolved
src/events.ts Outdated Show resolved Hide resolved
src/ui/custommessagehandler.ts Outdated Show resolved Hide resolved
rolandkakonyi and others added 4 commits October 10, 2023 13:45
Copy link
Contributor

@strangesource strangesource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as only nit picks are left.

Base automatically changed from fix-api-docs-problems to development October 11, 2023 20:05
@rolandkakonyi rolandkakonyi merged commit 72e319e into development Oct 11, 2023
6 checks passed
@rolandkakonyi rolandkakonyi deleted the add-missing-api-docs branch October 11, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants