Fix API docs problems #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandkakonyi
commented
Oct 10, 2023
Comment on lines
+42
to
+70
| const handleBitmovinNativeOfflineEvent = ( | ||
| data: BitmovinNativeOfflineEventData, | ||
| listeners: Set<OfflineContentManagerListener> | ||
| ) => { | ||
| listeners.forEach((listener) => { | ||
| if (!listener) return; | ||
|
|
||
| if (data.eventType === OfflineEventType.onCompleted) { | ||
| listener.onCompleted?.(data); | ||
| } else if (data.eventType === OfflineEventType.onError) { | ||
| listener.onError?.(data); | ||
| } else if (data.eventType === OfflineEventType.onProgress) { | ||
| listener.onProgress?.(data); | ||
| } else if (data.eventType === OfflineEventType.onOptionsAvailable) { | ||
| listener.onOptionsAvailable?.(data); | ||
| } else if (data.eventType === OfflineEventType.onDrmLicenseUpdated) { | ||
| listener.onDrmLicenseUpdated?.(data); | ||
| } else if (data.eventType === OfflineEventType.onDrmLicenseExpired) { | ||
| listener.onDrmLicenseExpired?.(data); | ||
| } else if (data.eventType === OfflineEventType.onSuspended) { | ||
| listener.onSuspended?.(data); | ||
| } else if (data.eventType === OfflineEventType.onResumed) { | ||
| listener.onResumed?.(data); | ||
| } else if (data.eventType === OfflineEventType.onCanceled) { | ||
| listener.onCanceled?.(data); | ||
| } | ||
| }); | ||
| }; | ||
|
|
There was a problem hiding this comment.
This was just moved to avoid exporting it.
rolandkakonyi
commented
Oct 10, 2023
There was a problem hiding this comment.
Got rid of MakeRequired as we don't need it at all.
rolandkakonyi
commented
Oct 10, 2023
src/utils.ts
Outdated
There was a problem hiding this comment.
Got rid of MakeRequired as we don't need it at all.
zigavehovec
reviewed
Oct 10, 2023
Base automatically changed from
add-api-docs-generation-command
to
development
October 11, 2023 09:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are warnings when generating docs using
yarn docs.Changes
SideLoadedSubtitleTrackAPI to provide withoutMakeRequiredhackChecklist
CHANGELOGentry - not applicable