Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ktlint #276

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Add ktlint #276

merged 4 commits into from
Oct 9, 2023

Conversation

zigavehovec
Copy link
Contributor

@zigavehovec zigavehovec commented Oct 5, 2023

Description

We have no linting for Kotlin code.

The actual code formatting is done here: #279

Changes

This PR adds:

Checklist

  • 🗒 CHANGELOG entry

@zigavehovec zigavehovec force-pushed the PRN-48/add-lint-to-kotlin-code branch from 27d8d24 to 2e92a6b Compare October 6, 2023 11:52
@zigavehovec zigavehovec force-pushed the PRN-48/add-lint-to-kotlin-code branch from 6999bdc to f0ff04a Compare October 9, 2023 07:25
@zigavehovec zigavehovec mentioned this pull request Oct 9, 2023
1 task
Copy link
Contributor Author

@zigavehovec zigavehovec Oct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added auto-generated gradle wrapper to the git, so that we can actually run gradlew tasks on the CI.

@zigavehovec zigavehovec self-assigned this Oct 9, 2023
@zigavehovec zigavehovec marked this pull request as ready for review October 9, 2023 09:18
Copy link
Contributor

@rolandkakonyi rolandkakonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Especially on the CONTRIBUTING.md changes! 🎉

Copy link
Contributor

@matamegger matamegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 👍

@zigavehovec zigavehovec merged commit 84d4619 into development Oct 9, 2023
4 of 5 checks passed
@zigavehovec zigavehovec deleted the PRN-48/add-lint-to-kotlin-code branch October 9, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants