Enable running CI workflow on all PRs #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matamegger
reviewed
Sep 22, 2023
.github/workflows/ci.yml
Outdated
| paths-ignore: | ||
| - '*.md' | ||
|
|
||
| push: | ||
| branches: [development] |
There was a problem hiding this comment.
I think we want to keep this. I think we only want the CI to run for push events to a pull request, but not on a push to any branch without PR.
There was a problem hiding this comment.
That makes sense, reverted in: e1bcaf6
matamegger
approved these changes
Sep 22, 2023
rolandkakonyi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When opening a PR that is targeting other than the
developmentbranch we don't run the CI workflow right now.This is problematic when working on a bigger feature with a chain of PRs open.
Changes
Enabled running the CI workflow on all PRs.
Checklist
CHANGELOGentry - not applicable