Skip to content

Commit

Permalink
Merge pull request #414 from bitmovin/maintenance/remove-commitlint
Browse files Browse the repository at this point in the history
Remove commitlint
  • Loading branch information
123mpozzi authored Mar 28, 2024
2 parents 7ad7eb6 + b3b8792 commit 93200aa
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 754 deletions.
4 changes: 0 additions & 4 deletions .husky/commit-msg

This file was deleted.

13 changes: 0 additions & 13 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -183,19 +183,6 @@ export default (spec: TestScope) => {
};
```

## Commit message convention

We follow the [conventional commits specification](https://www.conventionalcommits.org/en) for our commit messages:

- `fix`: bug fixes, e.g. fix crash due to deprecated method.
- `feat`: new features, e.g. add new method to the module.
- `refactor`: code refactor, e.g. migrate from class components to hooks.
- `docs`: changes into documentation, e.g. add usage example for the module..
- `test`: adding or updating tests, e.g. add integration tests using detox.
- `chore`: tooling changes, e.g. change CI config.

Our pre-commit hooks verify that your commit message matches this format when committing.

## Scripts

The `package.json` file contains various scripts for common tasks:
Expand Down
7 changes: 0 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,12 @@
"@babel/core": "7.22.10",
"@babel/preset-env": "7.22.10",
"@babel/runtime": "7.22.10",
"@commitlint/config-conventional": "17.7.0",
"@react-native-community/eslint-config": "3.1.0",
"@react-native/babel-preset": "0.73.18",
"@types/jest": "^28.1.2",
"@types/lodash.omit": "4.5.0",
"@types/react": "~18.2.26",
"babel-plugin-module-resolver": "5.0.0",
"commitlint": "17.7.1",
"eslint": "8.24.0",
"eslint-config-prettier": "8.5.0",
"eslint-plugin-prettier": "4.2.1",
Expand All @@ -92,11 +90,6 @@
"react": ">=17",
"react-native": ">=0.65"
},
"commitlint": {
"extends": [
"@commitlint/config-conventional"
]
},
"lint-staged": {
"*.(ts|tsx)": "eslint",
"*.(ts|tsx|js|jsx|md|json|yml|yaml)": "prettier --write"
Expand Down
Loading

0 comments on commit 93200aa

Please sign in to comment.