Merge PlaybackInfoProvider and PlayerHelper into PlayerDecorator
#79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonko1994
commented
Aug 24, 2024
conviva/src/main/java/com/bitmovin/analytics/conviva/PlayerAdapter.java
Outdated
Show resolved
Hide resolved
strangesource
approved these changes
Aug 26, 2024
stonko1994
changed the title
PlaybackInfoProvider and PlayerHelper into PlayerAdapterPlaybackInfoProvider and PlayerHelper into PlayerDecorator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
As preparation for the 'late player attaching' feature, which will make the Player optional inside
ConvivaAnalyticsIntegration,this PR merges the '3' Player-related instances into one. This will drastically improve the optional handling as it will only have one optional property to work against instead of 3 (Player,PlaybackInfoProviderandPlayerHelper)