-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce SSAI API #72
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strangesource
force-pushed
the
add-ssai-api
branch
from
July 2, 2024 09:12
8dbe099
to
b080b93
Compare
rolandkakonyi
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice implementation!
Merged
matamegger
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Just some questions and minor remarks.
conviva/src/main/java/com/bitmovin/analytics/conviva/ssai/SsaiApi.java
Outdated
Show resolved
Hide resolved
conviva/src/main/java/com/bitmovin/analytics/conviva/ssai/SsaiApi.java
Outdated
Show resolved
Hide resolved
conviva/src/main/java/com/bitmovin/analytics/conviva/ssai/DefaultSsaiApi.java
Show resolved
Hide resolved
…Api.java Co-authored-by: Matthias Tamegger <[email protected]>
strangesource
force-pushed
the
add-ssai-api
branch
from
July 2, 2024 14:52
9a52f65
to
83bae35
Compare
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SSAI ad tracking is not yet supported
Changes
The following files are public API:
Related Changes