Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce SSAI API #72

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Introduce SSAI API #72

merged 5 commits into from
Jul 2, 2024

Conversation

strangesource
Copy link
Contributor

@strangesource strangesource commented Jul 2, 2024

Problem

SSAI ad tracking is not yet supported

Changes

  • Introduce new SSAI API without using it
  • Add unit tests for SSAI API

The following files are public API:

Related Changes

@strangesource strangesource self-assigned this Jul 2, 2024
@strangesource strangesource marked this pull request as ready for review July 2, 2024 09:15
Copy link

@rolandkakonyi rolandkakonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice implementation!

@strangesource strangesource mentioned this pull request Jul 2, 2024
Copy link
Contributor

@matamegger matamegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Just some questions and minor remarks.

@strangesource strangesource merged commit 9d42de0 into develop Jul 2, 2024
3 checks passed
@strangesource strangesource deleted the add-ssai-api branch July 2, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants