Sync on collection update #1240
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 14, 2025
rfc2822
reviewed
Jan 18, 2025
There was a problem hiding this comment.
I wonder how this behaves when the services are refreshed. Doesn't it enqueue a lot of syncs during service detection (whenever a collection is updated)?
My ideas (may or may not make sense):
- A delay of a few seconds between the collection change and the sync (like for the push registration) could at least reduce the number of synchronizations during service detection.
- Or maybe pause it somehow?
- Maybe separate callbacks for the actions we want to observe (update read-only, update sync flag)? Has advantages and disadvantages.
Comment on lines
+294
to
+316
| /** | ||
| * Listener that enqueues a push registration worker when the collection list changes. | ||
| */ | ||
| class CollectionsListener @Inject constructor( | ||
| private val workerManager: SyncWorkerManager | ||
| ): DavCollectionRepository.OnChangeListener { | ||
|
|
||
| override fun onCollectionsChanged(account: Account?) { | ||
| account?.let { workerManager.enqueueOneTimeAllAuthorities(it) } | ||
| } | ||
|
|
||
| } | ||
|
|
||
| /** | ||
| * Hilt module that registers [CollectionsListener] in [DavCollectionRepository]. | ||
| */ | ||
| @Module | ||
| @InstallIn(SingletonComponent::class) | ||
| interface SyncWorkerManagerModule { | ||
| @Binds | ||
| @IntoSet | ||
| fun listener(impl: CollectionsListener): DavCollectionRepository.OnChangeListener | ||
| } |
There was a problem hiding this comment.
I think it should be in a separate file, because SyncWorkerManager's task is only to manage (enqueue, cancel) syncs.
The functionality that a method of SyncWorkerManager shall be called when collections change is a separate function and should be in a separate file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Nice to have for:
Short description
SyncWorkerManagerlisten to any collection changes and use the account passed along to trigger a one time sync of the whole account (not just the service which the collection belongs to - although that would prob be possible as well).Checklist