Exposing the simulation results through public functions in sim-lib #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlaKC
approved these changes
Aug 21, 2024
| @@ -770,7 +781,7 @@ impl Simulation { | |||
| } | |||
| }); | |||
|
|
|||
| let result_logger = Arc::new(Mutex::new(PaymentResultLogger::new())); | |||
| let result_logger = self.results.clone(); | |||
There was a problem hiding this comment.
Do we need both let result_logger = self.results.clone(); and let result_logger_clone = result_logger.clone(); below? Seems like we could reduce to a single clone?
There was a problem hiding this comment.
Hm. I think you need a results logger in the run_results_logger spawned task and the consume_simulation_results spawned task as well as the main simulation thread. So the Arc should have a reference count of 3? Which means you need to clone it twice. Am I understanding that correctly? Very possible I am missing something.
There was a problem hiding this comment.
Nope you're totally right - missed consume_simulation_results below!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Issue #196. Adds public functions to sim-lib that let a library user get the current simulation statistics.