Refactor: error messages to be concise and formatted correctly #40 #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamuAbba
changed the title
AdamuAbba
changed the title
carlaKC
reviewed
May 6, 2024
| @@ -171,7 +171,7 @@ pub struct ActivityDefinition { | |||
|
|
|||
| #[derive(Debug, Error)] | |||
| pub enum SimulationError { | |||
| #[error("Lightning Error: {0:?}")] | |||
| #[error("Lightning Error")] | |||
There was a problem hiding this comment.
Doesn't this just swallow the actual error that happened? I still think we should surface that information, and then handle it in a prettier way in the cli if required?
| @@ -13,7 +13,7 @@ const SECONDS_PER_MONTH: u64 = HOURS_PER_MONTH * 60 * 60; | |||
|
|
|||
| #[derive(Debug, Error)] | |||
| pub enum RandomActivityError { | |||
| #[error("Value error: {0}")] | |||
| #[error("Value error\nCaused by: {0}")] | |||
There was a problem hiding this comment.
Why do we have Caused by here but not below?
|
Closing due to inactivity, feel free to re-open if you've got an update here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes issue #40
This PR contains minor code changes that modify the structure of some error messages. I also did not modify some "one-liners" that seemed convenient enough. I'd appreciate a review and any pointers for adjustments thank you.