Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge bitcoin/bitcoin#31284: ci: Skip broken Wine64 tests by default
fa5e706 ci: Skip broken Wine64 tests by default (MarcoFalke) Pull request description: I don't think the unit tests run in Wine after the Windows cross-compilation have ever shown a true positive since the MSVC task was added. However, they are a source of frequent false-positives. Thus, disable them by default for now. Anyone can still enable them by setting `RUN_UNIT_TESTS=true`. A follow-up could run them on real Windows, see bitcoin/bitcoin#31176. Conceptually there are many other nightly tasks, which rarely find issues and are not run by default, like the valgrind or s390x tasks. So putting the Wine unit tests in the same bucket should be fine. ACKs for top commit: hebasto: ACK fa5e706, to avoid false-positives. willcl-ark: ACK fa5e706 Tree-SHA512: 6bd54470e4d5ce18923c5d724aba0dbf475d053d7097d3f87e822a455cc537b6ce5f0dfcc8ccd0719c12c5d0c8fc7355a6c84185a6c9b5d484d98aee763d0c49
- Loading branch information