-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce AddWalletButton and connect it to the AddWallet flow #418
base: main
Are you sure you want to change the base?
Conversation
e7747b2
to
4b79351
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4b79351
the space between the icon and the text is different than from master
maybe for follow up:
At the AddWallet page, the Skip
button in in the right top should get a condition to only have it when in the onboarding flow. Now in the app when you click add wallet button -> Add Wallet page has a skip button, which makes no sense. a cancel would be more appropriate
cc @GBKS |
Nice work adding this functionality. I did a review of the full flow (MacOS) and added my notes in the visual below. Some of them will not be relevant to the focus of this PR and should probably be better handled in a separate one. Let me know how you want to handle that. And in written form: 1. Wallet selector dropdown 2. Add a wallet screen 3. Choose a wallet name screen 4. Choose a password screen 5. Your wallet has been created screen 6. Back up your wallet screen 7. Activity screen post wallet creation |
src/qml/pages/main.qml
Outdated
} | ||
|
||
Component { | ||
id: addWallet | ||
id: addWalletFlow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be rebased over #427
4b79351
to
694025a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 694025a
@rabbitholiness, this is only the UI link to the existent flow (CreateName.qml
- not included in this PR), where there's a validator (dev's note: regexp qt class is deprecated and needs to be updated) which needs to be modified to include spaces as you said and I tested it too. Also to that flow we need to add functionality to the "Import wallet" and "View file" buttons, make the encryption not mandatory and perhaps as in Qt switch to the recently created wallet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 694025a
Nice one. Looks like there's an issue with the web prototype in that the menu does not disappear when entering the create wallet flow. I'll make a note of that. Something I noticed is that clicking the balance always toggle the menu to be visible. But when it is visible, and I click the balance again, the menu should disappear. Not having looked at the code at all, but knowing similar setups from building web apps, my assumption is that there is the click-outside-of-the-menu event handles is the reason for this. The mouse-down on the balance is counted as a click outside of the menu, which causes it to close. Then right after the click on the balance is triggered. Since the menu is now closed, it shows the menu again. So that mouse-down on the balance should not trigger the close (if that makes sense). Another tweak (outside of this PR probably) is to show a "Cancel" button in the top-left of the first screen of the create wallet flow. That flow can be entered in two ways, with each one requiring different top bar options, so they make sense in context:
|
These commits enable the "Add Wallet" button at the bottom of the Wallet Select menu on Desktop