Introduce Tooltip for the BlockClock navbar button #400
Conversation
There was a problem hiding this comment.
7453346
there should also be a tooltip state for when node is offline/stopped, i.e:
I pause the blockclock -> tooltip keeps displaying the blocktime from last online/sync time.
doesn't seem to be right
Good point. I will add some basic state status for paused/connecting/connected. I think i will just go with what the block clock currently displays then have the designers review. |
There was a problem hiding this comment.
tACK 7453346
I agree with wording about time "left" matching the BlockClock instead of "to go" as in figma, perhaps figma needs to be updated @GBKS?
-
Figma:
-
This PR:
It would be good to add the figma link and screenshot comparison in the description so reviewers could ACK easier.
I also agree with @johnny9 and @MarnixCroes about adding different states wording as currently one can see the some inconsistencies:
Downloading blocks (this one looks correct)
Paused
Connecting (after pausing)
Connecting (after sync completed/ blocktime determined)
Blocktime determined (this one looks correct)
|
Good one. I tested and found a few things. First, the screenshots:
As you can see, the text disappears in light mode, and the color of the tip does not adjust. On the web, it's possible to tie SVG colors to CSS color variables that automatically change when the theme changes. Not sure what the technique is for QML. For me, it switched straight from "Downloading blocks - Estimating" to "Blocktime - xyz". It then counted blocks from ~1.5M or so to the current number. For much of that time it showed the almost full red circle, which felt like something was broken. The tooltip should be placed 4-5px higher up, so the arrow tip overlaps with the button. From Figma: Good call with the extra states. Can we list out which states we need? I started putting some of them together. |
|
Also a question. I see text directly in the code. To simplify localization, should those be text reference IDs instead so the actual copy can be grabbed from a locale-specific dictionary? |
the qsTr() wrapper function is how localization is managed with Qt |
johnny9
force-pushed
the
tooltip
branch
2 times, most recently
from
1dbe3ee to
c97e4e5
Compare
The Tooltip will appear when hovering over the BlockClock tab button in the desktop navigation bar. It will show the current state of IBD.
Unfortunately that is an old bug we're aware of. It has to do with how we determine if IBD is finished or not.
I think those are the main ones at the moment. "Could not connect" is not included in my commit as we don't currently have that state until we integrate Network detection. Additionally, we'll probably want some error status as well. |
|
Update to to 8f8341f:
|
There was a problem hiding this comment.
tack 8f8341f
one q: why are tooltip-arrow-dark.png and tooltip-arrow-light.png different size?
The Tooltip will appear when hovering over the BlockClock tab button in the desktop navigation bar. It will show the current state of IBD.
Two things are different than the figma. The wording for remaining blocks matches what is shown on the BlockClock instead of what the figma shows and After sync, Blockheight is shown instead. Looking for opinions on both during review.