Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interactive color states to peers table #370

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

jarolrod
Copy link
Member

@jarolrod jarolrod commented Nov 10, 2023

Introduces color states for hover and and pressed to the peers in the peers table.

Light

Filled Hover Pressed
Screenshot 2023-11-09 at 7 10 37 PM Screenshot 2023-11-09 at 7 10 11 PM Screenshot 2023-11-09 at 7 10 20 PM

Dark

Filled Hover Pressed
Screenshot 2023-11-09 at 7 03 23 PM Screenshot 2023-11-09 at 7 03 18 PM Screenshot 2023-11-09 at 7 03 40 PM

Build Artifacts

Introduces color states for hover and and pressed to the peers in the
peers table.
Copy link
Contributor

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested LGTM e8a2bbc

why also for pressed? Is there anything supposed to happen? (sorry for my ignorance, first time running this repo)

@jarolrod
Copy link
Member Author

@MarnixCroes when pressed, it would go to the peer's detailed information screen, which is still being designed

Copy link
Contributor

@pablomartin4btc pablomartin4btc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK e8a2bbc

@hebasto hebasto merged commit 2f08efc into bitcoin-core:main Nov 23, 2023
8 of 9 checks passed
Copy link
Contributor

@pablomartin4btc pablomartin4btc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post merge tACK e8a2bbc

@jarolrod on pressed action, the item should not stay colored somehow? (like until you un-press it or press on another one?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants