ci, gha: Build Android artifacts #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hebasto
force-pushed
the
231025-android
branch
from
5db284f to
8d3533a
Compare
jarolrod
reviewed
Oct 26, 2023
| - uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: ${{ matrix.host.artifact }} | ||
| path: src/qt/android/build/outputs/apk/debug/android-debug.apk |
There was a problem hiding this comment.
Do we want to call this debug? config isn't being built as debug here.
Is it possible to give each android build a unique name? like android-arm64.apk, etc...
There was a problem hiding this comment.
Do we want to call this debug?
It is named by the build system.
config isn't being built as debug here.
The other artifact is "unsigned", btw.
Is it possible to give each android build a unique name? like android-arm64.apk, etc...
Artifacts already have unique names. Do you think a name collision here is a real concern for users of those artifacts?
Maybe someone else could adjust all related docs, including the pr template? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintroduces downloadable binary artifacts for macOS and Windows as it was on now decommissioned Cirrus CI.
Unfortunately, the implementation is suboptimal due to various reasons. For example,
qtpackage in depends fails using the default Android installation in Ubuntu image.The artifacts are available for downloading from https://github.com/bitcoin-core/gui-qml/actions/workflows/artifacts.yml.
Also refer to GitHub documentation: https://docs.github.com/en/actions/managing-workflow-runs/downloading-workflow-artifacts.
Links for build artifacts: