ci, gha: Build macOS and Windows artifacts #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hebasto
force-pushed
the
230909-gha-cross
branch
2 times, most recently
from
e7a71b6 to
a9fd4f9
Compare
hebasto
force-pushed
the
230909-gha-cross
branch
from
a9fd4f9 to
734ea40
Compare
jarolrod
approved these changes
Sep 10, 2023
There was a problem hiding this comment.
ACK 734ea40
Tested grabbing the CI artifacts. You must be logged into GitHub in order to do this, we should leave a note on this in the README here or in a follow-up
diff --git a/src/qml/README.md b/src/qml/README.md
index 9b51e1b8a..0d24f3e5e 100644
--- a/src/qml/README.md
+++ b/src/qml/README.md
@@ -4,7 +4,7 @@
This directory contains the source code for an experimental Bitcoin Core graphical user interface (GUI) built using the [Qt Quick](https://doc.qt.io/qt-5/qtquick-index.html) framework.
-Insecure CI artifacts are available for local testing of the master branch, avoiding the need to build:
+Unsecure CI artifacts are available for local testing of the master branch, avoiding the need to build (must be logged into github):
- for Windows: [`insecure_win_gui.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip)
- for Intel macOS: [`insecure_mac_gui.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip)
- for Apple Silicon macOS: [`insecure_mac_arm64_gui.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip)Additional updates to the README would be:
- removing the link for Android
- Updating links for master CI artifacts
Leaving this for someone else :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintroduces downloadable binary artifacts for macOS and Windows as it was on now decommissioned Cirrus CI.
Here are a few implementation details:
The artifacts are available for downloading from https://github.com/bitcoin-core/gui-qml/actions/workflows/artifacts.yml.
Also refer to GitHub's documentation: https://docs.github.com/en/actions/managing-workflow-runs/downloading-workflow-artifacts.
Links for macOS and Windows build artifacts: