fix warnings and enable -Werror #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neither rv nor port_removed are used, so remove them. Fixes the following warnings: | ../git/src/netlink/knet_manager.cc: In member function 'virtual bool basebox::knet_manager::portdev_removed(rtnl_link*)': | ../git/src/netlink/knet_manager.cc:256:7: error: unused variable 'rv' [-Werror=unused-variable] | 256 | int rv = 0; | | ^~ | ../git/src/netlink/knet_manager.cc:257:8: error: unused variable 'port_removed' [-Werror=unused-variable] | 257 | bool port_removed(false); | | ^~~~~~~~~~~~ Signed-off-by: Jonas Gorski <[email protected]>
ifindex is unsed, so remove it. Fixes the following warning: | ../git/src/netlink/cnetlink.cc: In member function 'int basebox::cnetlink::handle_source_mac_learn()': | ../git/src/netlink/cnetlink.cc:962:9: error: unused variable 'ifindex' [-Werror=unused-variable] | 962 | int ifindex = port_man->get_ifindex(p.port_id); | | ^~~~~~~ Signed-off-by: Jonas Gorski <[email protected]>
We don't do anything with the return value of lag_members.emplace, so no need to store it. Fixes the following build warning: | ../git/src/netlink/nl_bond.cc: In member function 'int basebox::nl_bond::add_lag_member(rtnl_link*, rtnl_link*)': | ../git/src/netlink/nl_bond.cc:203:10: error: variable 'lm_rv' set but not used [-Werror=unused-but-set-variable] | 203 | auto lm_rv = lag_members.emplace(lag_id, members); | | ^~~~~ Signed-off-by: Jonas Gorski <[email protected]>
Both rtnl_mdb_entry_get_ifindex() and nl_bridge::get_ifindex() return an
int, not a uint32_t, so change the type of port_ifindex to int.
Fixes the following warnings:
| ../git/src/netlink/nl_bridge.cc: In member function 'int basebox::nl_bridge::mdb_entry_add(rtnl_mdb*)':
| ../git/src/netlink/nl_bridge.cc:900:22: error: comparison of integer expressions of different signedness: 'uint32_t' {aka 'unsigned int'} and 'int' [-Werror=sign-compare]
| 900 | if (port_ifindex == get_ifindex()) {
| | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
| ../git/src/netlink/nl_bridge.cc: In member function 'int basebox::nl_bridge::mdb_entry_remove(rtnl_mdb*)':
| ../git/src/netlink/nl_bridge.cc:999:22: error: comparison of integer expressions of different signedness: 'uint32_t' {aka 'unsigned int'} and 'int' [-Werror=sign-compare]
| 999 | if (port_ifindex == get_ifindex()) {
| | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
Signed-off-by: Jonas Gorski <[email protected]>
dst is unused so drop it. Fixes the following warning: | ../git/src/netlink/nl_l3.cc: In member function 'int basebox::nl_l3::get_neighbours_of_route(rtnl_route*, std::deque<rtnl_neigh*>*, std::deque<basebox::nh_stub>*)': | ../git/src/netlink/nl_l3.cc:1433:8: error: unused variable 'route_dst' [-Werror=unused-variable] | 1433 | auto route_dst = rtnl_route_get_dst(route); | | ^~~~~~~~~ Signed-off-by: Jonas Gorski <[email protected]>
Now that we fixed all warnings, enable Werror to prevent any new ones from springing up. Signed-off-by: Jonas Gorski <[email protected]>
KanjiMonster
force-pushed
the
jogo_fix_warnings_werror
branch
from
386b73e
to
3c3267e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings are important and should be addressed, so make sure they cannot be ignored by enabling -Werror after fixing all warnings.
No functional changes.