fix duplicate route check for FRR #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support different kind of requests, add the option of passing flags. Signed-off-by: Jonas Gorski <[email protected]>
We need to pass RTM_F_FIB_MATCH as flags to RTM_GETROUTE to get the full route, else e.g. the dst will be a /32 resp. /128. Without this, the duplicate route check for filtering out FRR's temporary duplicate on-link routes won't trigger. Fixes: 96e14a8 ("nl_l3: ignore duplicated link routes from FRR") Signed-off-by: Jonas Gorski <[email protected]>
rubensfig
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the kernel replies with an artifical host route when using
RTM_GETROUTE. This means that comparing the route's dst with prefix will never be identical, unless the route added is a host route as well. To get the actual route in the kernel, we need to passRTM_F_FIB_MATCHin the flags. This makes it return the full route including protocol and priority.Difference via ip:
Fixes: 96e14a8 ("nl_l3: ignore duplicated link routes from FRR")