Skip to content
This repository has been archived by the owner on Feb 11, 2021. It is now read-only.

Commit

Permalink
Bugfix/format page type (#214)
Browse files Browse the repository at this point in the history 
* docs: mention forgotten fix in changelog

(and remove commits not relevant)

* Add formatting for page types

Co-authored-by: Vincent Velociter <[email protected]>
  • Loading branch information
@noblica @veloce
noblica and veloce authored Jun 18, 2020
1 parent db4e407 commit f999cf8
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
3 changes: 1 addition & 2 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,18 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline

### Bug Fixes

- fix useStaticQuery hook [#77](https://github.com/birkir/gatsby-source-prismic-graphql/issues/77) ([ba15d2b](https://github.com/birkir/gatsby-source-prismic-graphql/commit/ba15d2bf50d63593449c48f54a8c0009c6510e45))
- bump dep version to fix ERROR [#11321](https://github.com/birkir/gatsby-source-prismic-graphql/issues/11321) ([9500260](https://github.com/birkir/gatsby-source-prismic-graphql/commit/9500260c0cc81600e1b013b7e115275293ed0e89))
- change travis build to deploy stable version ([46854b8](https://github.com/birkir/gatsby-source-prismic-graphql/commit/46854b8af8b2fe90e8f944060be792eb75042448))
- fix post review ([9ecc671](https://github.com/birkir/gatsby-source-prismic-graphql/commit/9ecc6711116c05b4002c859ac77beeebe2164e73))
- fixing type & updating path-to-regexp to use new match function ([eff64d8](https://github.com/birkir/gatsby-source-prismic-graphql/commit/eff64d824438690b7c73ced8f923b5c2f661412d))
- handle pages with unicode characters ([fa698d5](https://github.com/birkir/gatsby-source-prismic-graphql/commit/fa698d56de2b539f237b18debad6752a92a3524c))
- multi-lang previews ([e4baba7](https://github.com/birkir/gatsby-source-prismic-graphql/commit/e4baba7bc2c5295bdbb9d20f083891dd127165b1))
- rollback code to older typescript version ([3cbb1f1](https://github.com/birkir/gatsby-source-prismic-graphql/commit/3cbb1f1d62c7fa97ca44d69e1d205423be50d118))
- sanitize accessToken option ([6cb96bf](https://github.com/birkir/gatsby-source-prismic-graphql/commit/6cb96bf37f6b258ebda817c06c6a5ab0c3dbc178))
- test if page exists to display preview real url ([8705eb9](https://github.com/birkir/gatsby-source-prismic-graphql/commit/8705eb99352fda6aab41a684a25d9f16ef86e836))
- unescape createRemoteFileNode url ([018efe2](https://github.com/birkir/gatsby-source-prismic-graphql/commit/018efe287d25c1750cfb1e69564a3ca670e693b1))
- unpublish preview for Multi-language ([9ec4f89](https://github.com/birkir/gatsby-source-prismic-graphql/commit/9ec4f896b64f79bae3415419deb671a6db6dff3e))
- update function doc ([0bb6b35](https://github.com/birkir/gatsby-source-prismic-graphql/commit/0bb6b3550766313624c751fb2369207471301d3c))
- update yarn lock so we can publish ([4736559](https://github.com/birkir/gatsby-source-prismic-graphql/commit/473655989804f046d99effb5b0491335300c19f9))

### Features

Expand Down
7 changes: 5 additions & 2 deletions packages/gatsby-source-prismic-graphql/src/gatsby-node.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,12 @@ exports.createPages = async ({ graphql, actions: { createPage } }: any, options:
endCursor: string = '',
documents: Edge[] = []
): Promise<Edge[]> {
// Format page.type so that the graphql query doesn't complain.
const pageTypeUnderscored = page.type.toLowerCase().split(' ').join('_');
const pageTypeFormatted = pageTypeUnderscored.charAt(0).toUpperCase() + pageTypeUnderscored.slice(1);
// Prepare and execute query
const documentType: string = `all${page.type}s`;
const sortType: string = `PRISMIC_Sort${page.type}y`;
const documentType: string = `all${pageTypeFormatted}s`;
const sortType: string = `PRISMIC_Sort${pageTypeFormatted}y`;

This comment has been minimized.

Sign in to view

Copy link
@cbasJS

cbasJS Oct 22, 2020 •
edited
Loading

I Have a question @noblica @veloce why the sortType value should finish with the letter "y"?

Few hours ago the value have thrown error in my project.

I replicated the last output query value. Just we suppose that page.type is equals to "Basic_page"

query AllPagesQuery($sortBy: PRISMIC_SortBasic_pagey) {
  prismic {
    allBasic_pages(sortBy: $sortBy, first: 20) {
      totalCount
    }
  }
}

Query response:

"message": "Unknown type \"PRISMIC_SortBasic_pagey\". Did you mean \"PRISMIC_SortBasic_page\", \"PRISMIC_Basic_page\", \"PRISMIC_WhereBasic_page\", \"PRISMIC_SortTest_page\", or \"PRISMIC_SortLanding_page\"?",

This comment has been minimized.

Sign in to view

Copy link
@noblica

noblica Oct 23, 2020

Author Contributor

No idea.
This PR/commit was related to formatting the page type in the correct way (this issue). All I did was replace the variable in sortType, as well as documentType.
I'm guessing Prismic requires the query to be that way, but I have no idea why.
const extraPageFields = options.extraPageFields || '';
const query: string = getDocumentsQuery({ documentType, sortType, extraPageFields });
const { data, errors } = await graphql(query, {
Expand Down

0 comments on commit f999cf8

Please sign in to comment.