Improve lag calculation and error handling in lagCmd #341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the
lagCmd
function to improve its reliability and error reporting. The main changes are:Added a check to detect and report cases where the consumer offset is greater than the high watermark. This helps identify potential inconsistencies in the data.
Improved error messages for better clarity when troubleshooting issues.
Enhanced resource management by ensuring the admin client is properly closed using
defer
.Only report lag values greater than zero, reducing noise in the output.
Minor code improvements for readability (e.g., renaming variables).
These changes should make the lag calculation more robust and informative, especially in edge cases or when dealing with topic compaction or message retention scenarios.
Testing:
Please review and let me know if any further changes are needed.