Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Shift to display pop-up #1269

Open
bossanovaorca opened this issue Aug 10, 2023 · 2 comments
Open

Use Shift to display pop-up #1269

bossanovaorca opened this issue Aug 10, 2023 · 2 comments

Comments

@bossanovaorca
Copy link

related #33

is it possible to add Shift as a hotkey option for displaying the pop up?

@birtles
Copy link
Member

birtles commented Aug 11, 2023

Hi!

I think it's possible. It's a little bit complicated because, by default, Shift is used to toggle tabs on the popup. Also, Shift is currently the only key available for scanning for kanji only.

So if the user selected Shift for looking up either text or images we'd need to:

  • Automatically unselect Shift from the keys to toggle tabs
  • Disable selecting Shift for displaying kanji only

So it's a little bit complicated.

Can I ask if there's any particular reason to prefer using Shift?

@bossanovaorca
Copy link
Author

ah ok, yeah I assumed it would be more complex than I imagined especially since 10ten already supports a bunch of hotkeys for various features

Can I ask if there's any particular reason to prefer using Shift?

it's mostly just out of habit after migrating over from Yomichan

@birtles birtles mentioned this issue Nov 27, 2023
11 tasks
@birtles birtles mentioned this issue Dec 6, 2023
7 tasks
@birtles birtles mentioned this issue Feb 26, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants